web-scrobbler / web-scrobbler

Scrobble music all around the web!
https://web-scrobbler.com
MIT License
2.48k stars 549 forks source link

In listenbrainz scrobbler suggest matching records from musicbrainz DB with recording_mbid #2442

Open ojsquire opened 4 years ago

ojsquire commented 4 years ago

When scrobbling to listenbrainz, it would be great if suggestions of matching records in the MusicBrainz database would come up together with the recording_mbid and the user can select the correct one, and then submit the recording_mbid in the payload along with the artist, track and album. The result would be that in ListenBrainz there is an exact match to the item listened to in the Musicbrainz database, rather than just a partial match based on artist/track/album. Another nice advantage of this aside from really improving the accuracy of listens, is that on Listenbrainz submitting the recording_mbid results in a clickable link to the match in MusicBrainz.

In order to do this, you would have to add an extra call to the LB API: after sending the initial payload (as is done now, though this time not actually submitted as a "listen"), you would then need to return some results back to the plugin, and then get the user to choose the correct record, then send a second payload with the recording_mbid which is actually stored as the "listen".

petitminion commented 3 years ago

why not just use the mbid of a one of the recording ? Without asking the user. And maybe create an option to allow user to manualy choose the mbid. This way, the submission is automatic and the user can choose if it want a more accurate date send to its listenbrainz account

ojsquire commented 3 months ago

I guess my thought here was that you'd very rarely have the recording_mbid to start with, since most listening services (e.g. Spotify) don't have this. But yeh, if you have it that makes sense. Maybe there could first be a check for that?