Add explicit nullable type where needed

web-token / jwt-framework

JWT Framework

MIT License

888 stars 105 forks source link

Add explicit nullable type where needed #561

Closed alexandre-daubois closed 6 months ago

alexandre-daubois commented 6 months ago

Target branch: 3.1.x

[x] It is a Bug fix
[ ] It is a New feature
[ ] It is related to dependencies

Includes:

[ ] Breaks BC
[ ] Deprecations

In the effort of making the Symfony CI green for 8.4 and make this library also deprecation-free for the next PHP version, here is a PR that adds nullable explicit types to the codebase.

Spomky commented 6 months ago

Many thank @alexandre-daubois,

This should be done with the latest branch and changes merged in https://github.com/web-token/jwt-framework/pull/558. Is it necessary to have it in this outdated branch as well?

alexandre-daubois commented 6 months ago

I didn't see this PR and wasn't sure this branch was outdated. You're right 3.4.x should be enough, thank you for pointing this out 🙂