web-vision / wv_file_cleanup

TYPO3 extension to cleanup your TYPO3 installation automatically of unused media assets.
GNU General Public License v3.0
2 stars 7 forks source link

Bug in 10.4.8 #8

Open IL-Michi opened 3 years ago

IL-Michi commented 3 years ago

I got this error in the new Version Call to undefined method TYPO3\CMS\Backend\Utility\BackendUtility::getModuleUrl() The Code is in this File and Line -> wv_file_cleanup/Classes/Controller/CleanupController.php line 311

DavidBruchmann commented 3 years ago

I haven't checked but probably the related core-change can be found in the installtool where the extension-scanner is scanning the files and displaying the corresponding changelog- and deprecation-messages. Hints which changes are required are usually part of the messages.

JanBartels commented 3 years ago

A quick & dirty fix:

        } catch (\Exception $e) {
            // Silent ignore exceptions
        } catch (\Throwable $e) {
        }

Add the catch for Throwables a few lines further down. This fix doesn't solve the undefined method call, but the corrected exception handling for PHP 7.4 keeps the BE-module running.

DavidBruchmann commented 3 years ago

Here is the migration description for the bug:
https://docs.typo3.org/c/typo3/cms-core/master/en-us/Changelog/9.3/Deprecation-85113-LegacyBackendModuleRoutingMethods.html#description

DavidBruchmann commented 3 years ago

In the current master the method is not used anymore so we'd likely just need a new tagged version which should also be released on TER.