search

web2py / pydal

A pure Python Database Abstraction Layer
BSD 3-Clause "New" or "Revised" License
491 stars 137 forks source link

RethinkDB Adapter support. #282

Open v3ss0n opened 9 years ago

v3ss0n commented 9 years ago

RethinkDB have a powerful query language , a bit similar to webp2y's DAL . Should be easy to add RethinkDB adapter.

Is there anyone working on ? If not i will start working on it.

gi0baro commented 9 years ago

Hi @v3ss0n, a RethinkDB adapter would be awesome. Unfortunately we had not enough time to start writing it: if you would like to start you're absolutely welcome!

v3ss0n commented 9 years ago

Should i start looking at NoSQL adapter? or Based on Mongo ?

mdipierro commented 9 years ago

Use Mongo as an example, but extend NoSQLAdapter.

v3ss0n commented 9 years ago

@mdipierro thanks a lot. i will start working on it soon.

kmcheung12 commented 8 years ago

@gi0baro Do we have criteria on picking what db to be supported? E.g. Cassandra is quite popular these days. Shall we add that support?

gi0baro commented 8 years ago

@kmcheung12 the support specific db engines is just a matter of developers working on them. Making a new adapter means knowing/learning a lot of specific sql commands in the specific engine dialect, and unfortunately, the main team doesn't have the necessary knowledge or the time to do that.

So, practically speaking, the main deal with adapters is to have skilled developers working on them :)

kmcheung12 commented 8 years ago

@gi0baro Sorry to bring the discussion here which is a bit off from this ticket. Does the features listed here supported by all adapters? Our team have been using a self-made cassandra adapter with limited set of operation. I'm hoping to expand its functionality to benefit broader audience.

gi0baro commented 8 years ago

@kmcheung12 don't worry :) Regarding the features of the adapters, you can certainly push an incomplete adapter, just remember to add a skip in the tests. Even if the adapter doesn't contains all the features supported in pyDAL, submitting to the other developers is a good chance to have other developers contributing to it :)