Closed dchoi27 closed 1 year ago
@dchoi27
I can see web3storage_pin_requests_total
, to be exposed in the metrics API endpoint.
Can you confirm it's what you expect?
From a quick look, the way Uploads and PinRequests are counted is consistent.
pin_requests_total
uploads_total
uploads_total{type="${type}"}
represent the total number of requests to upload/psa_pin_requests, whether they ended up being successful or not.
@dchoi27 Are you okay to close this out?
Sorry! Yes can close this out
In NFT.Storage, we count uploads with
type='remote'
in the Grafana (since it's in theupload
table anyway), but in Web3.Storage, we keep track of PSA pin requests in a separate table (and not inupload
). We should include this data in some form.My understanding is that, to be consistent, we'd include everything in
psa_pin_request
(though someone should double check this - for instance, I'm not sure if in NFT.Storage, we only show an upload withtype='remote'
if we can grab the first block whereas potentially in Web3.Storage we show all requests inpsa_pin_request
whether or not we were ever able to find the content). But let's do whatever filtering, etc. makes sense + is consistent.