search

web3-storage / web3.storage

DEPRECATED ⁂ The simple file storage service for IPFS & Filecoin
https://web3.storage
Other
503 stars 119 forks source link

Include pin requests in Uploads in Grafana dashboard #1100

Closed dchoi27 closed 1 year ago

dchoi27 commented 2 years ago

In NFT.Storage, we count uploads with type='remote' in the Grafana (since it's in the upload table anyway), but in Web3.Storage, we keep track of PSA pin requests in a separate table (and not in upload). We should include this data in some form.

My understanding is that, to be consistent, we'd include everything in psa_pin_request (though someone should double check this - for instance, I'm not sure if in NFT.Storage, we only show an upload with type='remote' if we can grab the first block whereas potentially in Web3.Storage we show all requests in psa_pin_request whether or not we were ever able to find the content). But let's do whatever filtering, etc. makes sense + is consistent.

flea89 commented 2 years ago

@dchoi27 I can see web3storage_pin_requests_total, to be exposed in the metrics API endpoint. Can you confirm it's what you expect?

From a quick look, the way Uploads and PinRequests are counted is consistent. pin_requests_total uploads_total uploads_total{type="${type}"} represent the total number of requests to upload/psa_pin_requests, whether they ended up being successful or not.

mbommerez commented 1 year ago

@dchoi27 Are you okay to close this out?

dchoi27 commented 1 year ago

Sorry! Yes can close this out