web3-storage / web3.storage

DEPRECATED ⁂ The simple file storage service for IPFS & Filecoin
https://web3.storage
Other
503 stars 119 forks source link

Add user/uploads API pagination and sorting to the js client #1585

Closed joshJarr closed 2 years ago

joshJarr commented 2 years ago

Related to: https://app.zenhub.com/workspaces/web3storage-product-6106d25b58fccc00105aedcb/issues/web3-storage/web3.storage/1362 Once PR 1501 is merged the GET user/uploads endpoint will then support additional functionality.

This additional functionality should be documented and added to the JS client. Acceptance Criteria:

As a user, I can

Pagination Can be achieved by supplying the endpoint with

Sorting Uploads can now be sorted on the API with

Filtering (optional) Existing filtering functionality exists with before, but now we can also filter with after

dchoi27 commented 2 years ago

Just confirming - this is net of #1408 (which looks like it's just for the API)? Did the behavior of the JS client change after merging #1408? Just looking to see how to prioritize this (though this issue seems like it could be a pretty quick win)

dchoi27 commented 2 years ago

Ooh, and for users using the w3 CLI, do you know if updating the client will automatically get it into the CLI, or do we need to do this in addition? (see: #1610) cc @mbommerez

mbommerez commented 2 years ago

We need to do an investigation into this, what it currrently does.

Also, since we migrate to w3up and its new CLI, not sure how much time we should spend on this?

dchoi27 commented 2 years ago

Yes, let's say we're not doing this.

mbommerez commented 2 years ago

Okay thanks, closing this out.