search

web3-storage / web3.storage

DEPRECATED ⁂ The simple file storage service for IPFS & Filecoin
https://web3.storage
Other
503 stars 119 forks source link

Web3storage repo - Switch to a organisation-wide Cloudflare token in GH #1815

Closed mbommerez closed 2 years ago

mbommerez commented 2 years ago

For maintenance sake and develop experience, we'd like to switch to org-level GitHub secret for Cloudflare token for the web3.storage organisation.

Once done, we can/should remove the CF_API_TOKEN secret from the individual repo's secrets.

mbommerez commented 2 years ago

PR to switch to org level token has been merged, not deployed. Waiting for confirmation from @hugomrdias that the CF_API_TOKEN secret has been deleted from this repo's secrets.

hugomrdias commented 2 years ago

its gone! we still have CLOUDFLARE_PAGES_API_TOKEN for some reason can you look into it please ?

mbommerez commented 2 years ago

thanks Hugo, we will look into this.

francois-potato commented 2 years ago

@hugomrdias CLOUDFLARE_PAGES_API_TOKEN and CLOUDFLARE_ACCOUNT_ID are used by wrangler for publishing staging and production websites.

If CLOUDFLARE_PAGES_API_TOKEN is the same as the new CF_TOKEN, we can remove CLOUDFLARE_PAGES_API_TOKEN and update the GH action. Is CLOUDFLARE_ACCOUNT_ID at the org level?

hugomrdias commented 2 years ago

yes its CF_ACCOUNT_ID and please update the gh action thank you

francois-potato commented 2 years ago

Thanks @hugomrdias; updated in https://github.com/web3-storage/web3.storage/pull/1848