web3-storage / web3.storage

DEPRECATED ⁂ The simple file storage service for IPFS & Filecoin
https://web3.storage
Other
503 stars 119 forks source link

Fix breadcrumbs for "products" pages #1926

Closed JeffLowe closed 2 years ago

JeffLowe commented 2 years ago

Breadcrumbs currently do not show for any of the product pages. Update site to ensure that breadcrumbs work /display for these pages.

We should likely show the following in the breadcrumbs:

Current breadcrumbs for Products page

Screen Shot 2022-09-22 at 11 21 53 AM

Example breadcrumbs for FAQ page (for reference)

Screen Shot 2022-09-22 at 11 19 43 AM

example of the tab title when on products page

Image

e-schneid commented 2 years ago

@JeffLowe I just wanted to call out that since we don't have a "Products" route (i.e., https://web3.storage/products), my current fix in PR is to add the crumbs "Home / w3link", "Home / Web3.Storage" and "Home / w3name". Let me know if this works. The hierarchy on the site is a little unusual, so it's not super obvious what's correct.

The crumbs may also be a bit off for the pages under Account as well (for example, the tokens screen should possibly have the crumbs "Home / Account / API Tokens", etc), but I've held off on changes for those for now, since we may need to do a general sweep of all crumbs and see which ones need to be cleaned up. I've refactored our breadcrumbs so it should be easier to configure them if we want to make some more changes.

JeffLowe commented 2 years ago

That seems acceptable for the crumbs ( eg Home / w3link). @dchoi27 let us know if we need to reconsider that approach.

THANK YOU for the refactor and thinking of ease of maintaining for future.
Regarding the accounts page(s) I see your concern. I think it's acceptable to leave it as is for now, but feel free to override me if there is a concern @dchoi27

dchoi27 commented 2 years ago

Works for me!