web3-storage / web3.storage

DEPRECATED ⁂ The simple file storage service for IPFS & Filecoin
https://web3.storage
Other
503 stars 119 forks source link

Website: social media preview not rendering #1984

Closed meghansinnott closed 1 year ago

meghansinnott commented 2 years ago

The social media preview for web3.storage is not rendering. SocialMediaPreview

JeffLowe commented 2 years ago

Thanks for the repot. Looks like the full route for the og image is not getting insert. We'll get that fixed.

meghansinnott commented 2 years ago

@e-schneid the issue persists on for blog links. Is this something that can be fixed?

jchris commented 2 years ago

Here is an example of not working

Screen Shot 2022-10-21 at 9 58 33 AM

https://twitter.com/Web3Storage/status/1583487397924605952?s=20&t=GPOpzxY-QypRSX2wdtbM6A

e-schneid commented 1 year ago

It's now in PR to fix this on the blog.

meghansinnott commented 1 year ago

@JeffLowe, @e-schneid, @jchris - the preview is still not consistently showing for the web3.storage blog when I share via Twitter.

https://twitter.com/Web3Storage/status/1592969257666711558?s=20&t=qY0vK1QUc818YAwRCmbGug

cmunns commented 1 year ago

@meghansinnott I've done some testing on this and it appears that on the home blog url the preview only works if you add a trailing slash. I've confirmed that the twitter card meta tags are all present and correct and we aren't missing any optional settings that would help rectify this issue but at least we have a solution on how to fix.

https://user-images.githubusercontent.com/1189523/203121198-fd04f1b4-f0ad-479b-a7a7-70e4a457b054.mov

meghansinnott commented 1 year ago

That's wonderful! Thank you, Adam!

On Mon, Nov 21, 2022 at 9:27 AM Adam Munns @.***> wrote:

@meghansinnott https://github.com/meghansinnott I've done some testing on this and it appears that on the home blog url the preview only works if you add a trailing slash. I've confirmed that the twitter card meta tags are all present and correct and we aren't missing any optional settings that would help rectify this issue but at least we have a solution on how to fix.

https://user-images.githubusercontent.com/1189523/203121198-fd04f1b4-f0ad-479b-a7a7-70e4a457b054.mov

— Reply to this email directly, view it on GitHub https://github.com/web3-storage/web3.storage/issues/1984#issuecomment-1322412420, or unsubscribe https://github.com/notifications/unsubscribe-auth/AK5OX6D5RUNDDXDGDLZZ4I3WJOWJLANCNFSM6AAAAAAQ2DI7FE . You are receiving this because you were mentioned.Message ID: @.***>

meghansinnott commented 1 year ago

@cmunns - Sorry to report that the trailing hash hack isn't working. TrailingHash

JeffLowe commented 1 year ago

@meghansinnott the social share on this post https://blog.web3.storage/posts/w3up-for-ipfs-users is now fixed. In this instance, it has nothing to do with the trailing / and everything to do with how the featured image is uploaded and included in the post during authoring. I'm documenting the issue and the needed fix in a separate ticket. Know if you encounter this issue again, a quick fix is to ask the author of the post to upload the featured image and resave & republish the post. This is the short term fix until we resolve the image upload issue for the long term.