search

web3 / web3.js

Collection of comprehensive TypeScript libraries for Interaction with the Ethereum JSON RPC API and utility functions.
https://web3js.org/
Other
19.22k stars 4.92k forks source link

Websocket Library options for Basic Auth #1524

Closed Freyert closed 6 years ago

Freyert commented 6 years ago

I'm very excited about websocket support since subscriptions are a huge feature. However, I'm already running into a major issue with the current websocket library: it doesn't support basic auth.

According to RFC 6455 any authentication method supported by HTTP should be supported during the upgrade.

I think you may also be able to get away without forking the project to obtain browserify support by using https://github.com/heineiuo/isomorphic-ws to handle the transition between nodejs and browser.

If you are amenable to a PR I'd love to take a crack at swapping out the libraries.

peterbroadhurst commented 6 years ago

I've just submitted a PR here for consideration: https://github.com/ethereum/web3.js/pull/1541

frozeman commented 6 years ago

Thanks!