web3 / web3.js

Collection of comprehensive TypeScript libraries for Interaction with the Ethereum JSON RPC API and utility functions.
https://web3js.org/
Other
19.14k stars 4.9k forks source link

Investigate A Better E2E Test for Web3Eth.submitWork #5064

Open spacesailor24 opened 2 years ago

spacesailor24 commented 2 years ago

With EL and CL merge this function will be discarded as POW will be removed. But I think for other evm POW based NWs if any one want to use web3.js we can test it in some future release:

  1. Infrastructure setup ( fully synced local testnet Ethereum client that is enabled for mining )

  2. get results of eth_getWork Returns the hash of the current block, the seedHash, and the boundary condition to be met (“target”).

  3. use some external process for calculation of correct nonce , new proposed block hash and mix digest.( May be some external mining module like https://github.com/ethereum-mining/ethminer#ethminer )

  4. submit that via submitWork

_Originally posted by @jdevcs in https://github.com/ChainSafe/web3.js/pull/5056#discussion_r878380518_

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. If you believe this was a mistake, please comment.

mconnelly8 commented 1 year ago

Low priority and moving to Ice Box. Issue is more of investigation.