search

web3 / web3.js

Collection of comprehensive TypeScript libraries for Interaction with the Ethereum JSON RPC API and utility functions.
https://web3js.org/
Other
19.19k stars 4.91k forks source link

[plugin] customTransactionSchema follow-up #7273

Open nicolasbrugneaux opened 2 hours ago

nicolasbrugneaux commented 2 hours ago

Greetings! Thanks again for merging my work in

Sadly, it's still not enough to allow for extra fields in transactions. Indeed, this function getEthereumjsTxDataFromTransaction is trimming down fields despite being validated earlier

nicolasbrugneaux commented 2 hours ago

I'm happy to propose changes but I just wanted to get your opinion on what you think should happen, I believe the function is somewhat redudant and could be limited to field aliasing (data<->input, gas<->gasLimit)