Type of `Web3Eth.calculateFeeData` Param `baseFeePerGasFactor` Should Support Decimals

web3 / web3.js

Collection of comprehensive TypeScript libraries for Interaction with the Ethereum JSON RPC API and utility functions.

https://web3js.org/

Other

19.27k stars 4.94k forks source link

Type of `Web3Eth.calculateFeeData` Param `baseFeePerGasFactor` Should Support Decimals #7321

Open danforbes opened 1 week ago

danforbes commented 1 week ago

When specifying the baseFeePerGasFactor for the Web3Eth.calculcateFeeData method, users may wish to specify a percentage, such as %112.5. To support this, the type of this parameter should be changed from bigint to a type that supports decimal values.

TemirlanBasitov commented 6 days ago

you can use baseFeePerGasFactor: number = 2, instead of bigint(2)

TemirlanBasitov commented 6 days ago

https://github.com/web3/web3.js/pull/7332