search

web3 / web3js-landing

https://web3js.org
18 stars 39 forks source link

Update pluginList.ts #63

Closed evelynnmimijae closed 2 months ago

evelynnmimijae commented 3 months ago

Adding web3-plugin-faucettestnet2 to the plugin list that's published on NPM Registry.

evelynnmimijae commented 3 months ago

Hi @evelynnmimijae , thanks for submiting this! Can you please update the README.md file of the plugin with a getting started guide please? because when you check the NPM package you can only see a 'web3 plugin template' but not a guide to use the plugin or what's the plugin about Thank you!

@SantiagoDevRel Yes, I absolutely need to do that! Do I need to delete the registry or simply create an update/new version to edit the README file?

SantiagoDevRel commented 3 months ago

@evelynnmimijae You only need to update the README in the plugin repository, no need to edit anything else in this PR

danforbes commented 3 months ago

The README actually looks good on the repository. @evelynnmimijae did you update the README after you did the NPM release? If so, you may just need to do another NPM release to get NPM to pick up the README.

SantiagoDevRel commented 3 months ago

Ohh right thanks for catching this @danforbes @evelynnmimijae what you need to do is the following:

  1. Go to package.json
  2. Update the "version": "1.0.0", to "version": "1.0.1"
  3. run npm publish again Done!
evelynnmimijae commented 3 months ago

Yes, thank you @danforbes!

@SantiagoDevRel I updated the README.

SantiagoDevRel commented 2 months ago

For visibility: I just reviewed the plugin, waiting until it can work 100% before publishing it here

https://www.npmjs.com/package/web3-plugin-faucettestnet2

evelynnmimijae commented 2 months ago

@SantiagoDevRel, can you tell me anything about the test file? I keep failing the test, which is probably why the plugin isn't working.

Screenshot from 2024-07-18 15-51-25