When submitting an invalid transaction all nodes try to mine

web3coach / the-blockchain-bar

The source-code for: "Build a Blockchain from Scratch in Go" eBook.

https://web3.coach

GNU Lesser General Public License v3.0

499 stars 184 forks source link

Closed lehmann-labs closed 3 years ago

lehmann-labs commented 3 years ago

Given:

Account with a certain balance When:
- Transaction value is higher then value hold in balance for the account Then:
All nodes try to mine the block, the first successful can not add the block to the chain (as transaction is invalid), all the other nodes continue mining.

Maybe it would be good to have some pre-mining validation of each transaction?

web3coach commented 3 years ago

Definitely! One of the exercises I planned to add for the students. Do you want to take on the opportunity and create a PR? It's an easy fix.

web3coach commented 3 years ago

Hi, Added the pre-mining validation. Good idea @lehmann-labs !