search

web3p / ethereum-tx

Ethereum transaction library in PHP.
https://www.web3p.xyz/ethereumtx.html
MIT License
183 stars 63 forks source link

Strip 0x prefixed private key #31

Closed sc0Vu closed 3 years ago

sc0Vu commented 3 years ago

Fix #27 #28

Maybe #30?

It seems 0x prefixed private key break the ec sign.

codecov[bot] commented 3 years ago

Codecov Report

Merging #31 (534fa0d) into master (5b14653) will increase coverage by 0.24%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master      #31      +/-   ##
============================================
+ Coverage     88.80%   89.05%   +0.24%     
- Complexity       64       65       +1     
============================================
  Files             1        1              
  Lines           134      137       +3     
============================================
+ Hits            119      122       +3     
  Misses           15       15
Impacted Files Coverage Δ Complexity Δ
src/Transaction.php 89.05% <100.00%> (+0.24%) 65.00 <0.00> (+1.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b14653...534fa0d. Read the comment docs.