search

web3p / web3.php

A php interface for interacting with the Ethereum blockchain and ecosystem. Native ABI parsing and smart contract interactions.
MIT License
1.17k stars 550 forks source link

Close connection after stream read #135

Closed 1099511627776 closed 5 years ago

1099511627776 commented 5 years ago

Prevent out of file resources during intensive using.

codecov-io commented 5 years ago

Codecov Report

:exclamation: No coverage uploaded for pull request base (master@9dd5056). Click here to learn what that means. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #135   +/-   ##
=========================================
  Coverage          ?   89.19%           
  Complexity        ?      664           
=========================================
  Files             ?       47           
  Lines             ?     1462           
  Branches          ?        0           
=========================================
  Hits              ?     1304           
  Misses            ?      158           
  Partials          ?        0
Impacted Files Coverage Δ Complexity Δ
src/RequestManagers/HttpRequestManager.php 78.37% <100%> (ø) 12 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9dd5056...b0b1841. Read the comment docs.

sc0Vu commented 5 years ago

@1099511627776 Thanks for this pr, would you like to fix indent from L67 to L69?

1099511627776 commented 5 years ago

@sc0Vu Hi, Fixed indents.

sc0Vu commented 5 years ago

@1099511627776 Thanks!