search

web3p / web3.php

A php interface for interacting with the Ethereum blockchain and ecosystem. Native ABI parsing and smart contract interactions.
MIT License
1.16k stars 542 forks source link

Implementation of Contract::getEventLogs() and improved general comments and error messages #196

Open Nanolucas opened 3 years ago

Nanolucas commented 3 years ago

Updated comments and error messages to improve clarity and consistency

codecov-io commented 3 years ago

Codecov Report

Merging #196 (bb9f9f0) into master (17472b5) will decrease coverage by 2.09%. The diff coverage is 5.79%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #196      +/-   ##
============================================
- Coverage     87.39%   85.29%   -2.10%     
- Complexity      729      750      +21     
============================================
  Files            47       47              
  Lines          1594     1632      +38     
============================================
- Hits           1393     1392       -1     
- Misses          201      240      +39
Impacted Files Coverage Δ Complexity Δ
src/Contract.php 68.36% <0.00%> (-7.56%) 179.00 <21.00> (+21.00) :arrow_down:
src/Contracts/Ethabi.php 77.85% <100.00%> (ø) 66.00 <2.00> (ø)
src/RequestManagers/HttpRequestManager.php 78.37% <0.00%> (-0.57%) 12.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17472b5...bb9f9f0. Read the comment docs.

Nanolucas commented 3 years ago

Completed implementation of Contract::getEventLogs() functionality, as initially described/requested in https://github.com/web3p/web3.php/issues/93

phillmorgan28 commented 2 years ago

Can this be merged into PHP 8 branch?