search

web3p / web3.php

A php interface for interacting with the Ethereum blockchain and ecosystem. Native ABI parsing and smart contract interactions.
MIT License
1.16k stars 543 forks source link

weird logic of enabling/disabling batch #316

Open DieselPower200 opened 1 year ago

DieselPower200 commented 1 year ago

https://github.com/web3p/web3.php/blob/cede0cc410363ec6182a732e98bb017e421352f4/src/Web3.php#L284

public function batch($status)
    {
        $status = is_bool($status);

        $this->provider->batch($status);
    }

Probably there is boolval($status) is required becase calling batch(true) batch(false) is always true. I have to use batch('false') to stop batch requests