search

web3ui / web3uikit

Lightweight reusable Web3 UI components for dapps.
https://web3uikit.com
MIT License
1.72k stars 269 forks source link

[Modal]: add z-index prop to modal #964

Closed AbhinavMV closed 1 year ago

SebastianLF commented 1 year ago

Interested to work on this one. Can you give more context, please?

AbhinavMV commented 1 year ago

Hey @SebastianLF, Great to hear that you are interested to work on this 🤩

Context: The modal component has hardcoded z-index right now. I was thinking of adding a new prop to the component called -> zIndex . And based on this value the modal will get a z-index. Also whatever value is used right now should be the default value. so that there are no breaking changes 😄

I will assign you this issue. Let me know if you want any help, btw you can join moralis discord channel and ask for any help in web3uikit channel 🙌🏻

SebastianLF commented 1 year ago

Thanks for this clear explanation. Let's try it!

AbhinavMV commented 1 year ago

Hey @SebastianLF 👋🏻 How is this task going? Let me know if you are facing any issues 🙌🏻

SebastianLF commented 1 year ago

Sorry, will work today on it :)

AbhinavMV commented 1 year ago

Nice work @SebastianLF 🥳

Closed as completed by #981