search

web3wagers / gostarkme

Funds recollection project in Starknet ecosystem
http://web3wagers.github.io/gostarkme/
GNU Affero General Public License v3.0
15 stars 51 forks source link

Fix: move increment id because the first fund was with id 0. #119

Closed EmmanuelAR closed 1 month ago

EmmanuelAR commented 1 month ago

Fix: move increment id because the first fund was with id 0.

adrianvrj commented 1 month ago

@EmmanuelAR what is the reason for this change? it is known in programming that ids normally start with 0, as in any array the first position is taken as 0

adrianvrj commented 1 month ago

I get it now, 0 would denote NULL if we are talking about table objects, great catch g, appreciate the change

EmmanuelAR commented 1 month ago

I see like in order, if we want to show the funds will be weird to see a id in 0, another point is that i see like a sql tables, the first register will !

adrianvrj commented 1 month ago

@EmmanuelAR is this bug present in the other manager?

EmmanuelAR commented 1 month ago

@EmmanuelAR is this bug present in the other manager?

No, for the donator manager we use the donator address as key