Added GitHub Actions - Githubissues

web4bio / webgen

WebGen Vertically Integrated Project

https://web4bio.github.io/webgen/main/html/

11 stars 26 forks source link

Added GitHub Actions #320

Closed ericr491 closed 3 years ago

ericr491 commented 3 years ago

I currently set it up so that it generates the docs on changes to the development branch. Thoughts?
Also, I need someone who has access to approve PR to put their email and username in the main.yml.

enemeth19 commented 3 years ago

I currently set it up so that it generates the docs on changes to the development branch. Thoughts?

Sounds good to me

Also, I need someone who has access to approve PR to put their email and username in the main.yml.

Shouldn't anyone in the group be able to approve PRs?

ericr491 commented 3 years ago

Not that I am aware of, only Kevin, Carolyn, Adit, and you have write access to the repo.

enemeth19 commented 3 years ago

Okay, let's double check with @rmoffitt on this. Not sure if repo access settings were updated/changed at the beginning of this semester, and would be good to know

adit-anand commented 3 years ago

The person who makes the PR can't approve it (GitHub's version of safety bumpers). Also, is there a reason why we're merging this into the master branch? @ericr491

enemeth19 commented 3 years ago

I think it might be better practice to merge this into the development branch. What do you think? @ericr491

ericr491 commented 3 years ago

I am not 100% sure that GitHub will detect it on non master branch, but give it a try won't hurt.

enemeth19 commented 3 years ago

Looks like something is off @ericr491

enemeth19 commented 3 years ago

ericr491 commented 3 years ago

Opps, forgot to get rid of plco.js.