Closed ericr491 closed 3 years ago
I currently set it up so that it generates the docs on changes to the development branch. Thoughts?
Sounds good to me
Also, I need someone who has access to approve PR to put their email and username in the main.yml.
Shouldn't anyone in the group be able to approve PRs?
Not that I am aware of, only Kevin, Carolyn, Adit, and you have write access to the repo.
Okay, let's double check with @rmoffitt on this. Not sure if repo access settings were updated/changed at the beginning of this semester, and would be good to know
The person who makes the PR can't approve it (GitHub's version of safety bumpers). Also, is there a reason why we're merging this into the master branch? @ericr491
I think it might be better practice to merge this into the development branch. What do you think? @ericr491
I am not 100% sure that GitHub will detect it on non master branch, but give it a try won't hurt.
Looks like something is off @ericr491
Opps, forgot to get rid of plco.js.