FIX jsdoc in mergeexpression

web4bio / webgen

WebGen Vertically Integrated Project

https://web4bio.github.io/webgen/main/html/

11 stars 26 forks source link

FIX jsdoc in mergeexpression #339

Closed kaczmarj closed 2 years ago

kaczmarj commented 3 years ago

jsdoc complained about the return type in this function. this commit resolves that problem. the fix is to use Array.<TYPE> instead of TYPE[]. i am confused, however, because sometimes using TYPE[] does work.

this also replaces (number | null) with the more compact syntax ?number.

let's wait on this PR until #328 is merged.

replaces #337

adit-anand commented 3 years ago

@kaczmarj Is this issue in any way related to PR #329? If not, I'll merge this into development.

kaczmarj commented 3 years ago

nope, this is not related to #329. but i was thinking of waiting until #328 is merged so we can test that this PR fixes the jsdoc error in mergeExpression.

kaczmarj commented 3 years ago

jsdoc has passed! nice!!! this pr is ready for review.