search

web4bio / webgen

WebGen Vertically Integrated Project
https://web4bio.github.io/webgen/main/html/
11 stars 26 forks source link

orphaned function! displayNumberBarcodesAtIntersection() #340

Closed kaczmarj closed 2 years ago

kaczmarj commented 3 years ago

why has displayNumberBarcodesAtIntersection() been commented out? @prvshenoy01 the git blame shows you did it in https://github.com/web4bio/webgen/commit/170fe59dc1fc695a60004f34ec2086a5b7892752. do you recall why?

in our small group, we were tracing function calls and realized displayNumberBarcodesAtIntersection() is not called anywhere.

https://github.com/web4bio/webgen/blob/7f41f695afbef58b5373625e6de3807e260df364/main/js/plots/createPieCharts.js#L544

prvshenoy01 commented 3 years ago

I don't believe I commented that out but I just went back to trace my changes and somehow that became a part of my changes for that commit when I pulled from dev. So I don't know if there is a reason why it was commented out but I can uncomment it.

kaczmarj commented 3 years ago

no worries. i don't know what it does tbh, but if we don't need it, then there's a bunch of stuff we can remove.