search

web4bio / webgen

WebGen Vertically Integrated Project
https://web4bio.github.io/webgen/main/html/
11 stars 26 forks source link

Plots jsdocs #369

Closed amaraim22 closed 2 years ago

amaraim22 commented 2 years ago

new pr: for createHeatmap.js, there's only one large function. we were talking about moving functions out if some functions were used by the code in createViolinPlot.js. there's also the benefit of moving helpers functions out of the main large function for better documentation. I just made this pr if anyone has any opinions/feedbacks on anything written. there will also be more commits later on added to this as well.

kaczmarj commented 2 years ago

@amaraim22 - these changes look great to me. anything else you wanted to do in this pr? or is it ready to go?

amaraim22 commented 2 years ago

@kaczmarj it is ready to go but there might still be more to be documented. if that's the case then i'll just make a new pr?

kaczmarj commented 2 years ago

@kaczmarj it is ready to go but there might still be more to be documented. if that's the case then i'll just make a new pr?

yeah i think that's a good idea. it will be good to merge in these changes, and future changes can come in other prs. before we merge, could you remove the unused function wrap ? then it's good on my end