search

web4bio / webgen

WebGen Vertically Integrated Project
https://web4bio.github.io/webgen/main/html/
11 stars 26 forks source link

Empty Intersection of Barcodes Errors Out Plots #459

Closed adit-anand closed 2 months ago

adit-anand commented 1 year ago

Error handling needs to be implemented for plot generation when the set of intersecting barcodes (from pie chart sector selection) is empty. image

adit-anand commented 4 months ago

Resolved with most recent updates to branch "adit"

adit-anand commented 4 months ago

@enemeth19 At the moment, an empty barcode intersection results in plots being generated for all patients (i.e., we visualize all the patients' data when the filters produce an empty list of barcodes).

What are your thoughts on displaying a pop-up message indicating the combination of filters produces no barcodes?

enemeth19 commented 4 months ago

@enemeth19 At the moment, an empty barcode intersection results in plots being generated for all patients (i.e., we visualize all the patients' data when the filters produce an empty list of barcodes).

What are your thoughts on displaying a pop-up message indicating the combination of filters produces no barcodes?

That definitely sounds like a good idea.

However, if a user does not make any selections at all in the data filtering (ie, pie chart) section, then I think we should still display the data for all patients in the heatmap and violin plots. How does that sound to you @adit-anand ?

adit-anand commented 4 months ago

That works with me, thank you for the input Erika.