webOS-ports / luneos-testing

Public testing images for LuneOS
4 stars 0 forks source link

Can't uninstall app from launcher #11

Closed Tofee closed 2 years ago

Tofee commented 2 years ago

Describe the bug When opening the launcher, and doing a long-press, a "cross" is available for user-installed apps that can be uninstalled. But clicking on that cross doesn't work. In the journal, I see: LunaAppManager[1953]: cbRemove: name provided = [com.palm.app-museum2], getPackageInfoByPackageId FAIL, getPackageInfoByAppId FAIL - aborting remove

To Reproduce Steps to reproduce the behavior:

  1. Install a user app (through Preware2 for instance)
  2. Open launcher
  3. Long press on a user-installed app
  4. Click on cross
  5. See error in journal

Expected behavior App should get uninstalled

Screenshots N/A

Smartphone (please complete the following information):

Additional context Add any other context about the problem here.

Herrie82 commented 2 years ago

@Tofee: We probably simply need to update this call: https://github.com/webOS-ports/luna-next-cardshell/blob/master/qml/LaunchBar/FullLauncher.qml#L669

Into something similar to this: luna://com.webos.appInstallService/remove '{ \"id\": \"$ipkname\", \"subscribe\": true }'" as per https://github.com/codepoet80/webos-ports-sdk/blob/master/scripts/lune-install.sh#L58

Tofee commented 2 years ago

Yes, iirc it's what I wrote on the command line to uninstall the app manually, and it worked

Tofee commented 2 years ago

Fixed with https://github.com/webOS-ports/luna-next-cardshell/pull/331