search

webRTC-io / webrtc.io-client

drop-in client code for webrtc.io Highly experimental technology
143 stars 96 forks source link

fixes, and debug flag #34

Closed mudcube closed 11 years ago

mudcube commented 11 years ago

This pull request includes an additional fix for my previous submitted patch. I've been using this for a few days now, with lots of reloads, on HTTP and HTTPS servers, pre-authorized, post-authorized, and seemingly working without a hitch. Basically, sometimes events fire before other events (when they're expected to happen in a certain order), so this makes things a bit more fuzzy, so it doesn't matter so much which order things happen.

rtc.connections is now has garbage collection (in the same places as rtc.peerConnections/rtc.dataChannels)

I've also added a "debug" variable to turn on/off console.log'ing

[fixed whitespace issue on previous pull request]

sarenji commented 11 years ago

Looks great, I had some comments. Happy to merge afterward!

mudcube commented 11 years ago

Oh, cool, that makes things easier! I've made the tweaks as recommended.

sarenji commented 11 years ago

Thanks a lot for this! I had to merge it manually since there were problems with Travis recognizing your repository. There were some odd merge errors, but I think it should be fine?