Some Feedback - Githubissues

webadvanced / Structuremap.MVC5

Apache License 2.0

21 stars 9 forks source link

Closed jeremydmiller closed 10 years ago

jeremydmiller commented 10 years ago

Just 2 things, and I think the first one is nitpicking.

In your IoC.Initialize(); I'd strongly suggest using a Container built from a separate Registry class. I'm trying to encourage folks to stop using the static ObjectFactory wrapper around Container if possible
I might be missing where you did it, but you probably want to dispose the main application Container on application shutdown

valmont commented 10 years ago

Hey Jeremy, thanks for the feedback. I have updated the implementation, let me know if it's a pass.