search

webai-community / aquarium

BSD 3-Clause "New" or "Revised" License
26 stars 7 forks source link

Implement --framebuffer-size #169

Open hujiajie opened 4 years ago

hujiajie commented 4 years ago

Currently Aquarium renders directly to the framebuffer the window system gives to it. The framebuffer size is determined by the GLFW window size (and DPI), which means the maximum will be limited by screen size. To harness the GPU, sometimes it's desired to use an extremely large offscreen framebuffer for rendering, whose size is given by --framebuffer-size, and then "blit" to the window.

hujiajie commented 4 years ago

@Honry Let's track the issue here. I'm afraid it's a non-trivial change. With current code path, I'm not sure if a HiDPI screen may help.

Honry commented 4 years ago

@hujiajie, thanks for your great support! It's a nice but not must to have feature for me, so please take your time on this.

JiangYizhou commented 4 years ago

This sounds like super sampling, how about '--super-sampling'?

hujiajie commented 4 years ago

@JiangYizhou, thanks for the comment. --framebuffer-size stems from the term used by GLFW.