search

webark / ember-cli-styles

4 stars 2 forks source link

feat(preprocessor): updated preprocessor to not include any by default. #19

Closed webark closed 2 years ago

webark commented 2 years ago

All style preprocessors must be manually added in order to process. Will still export the default set defined in https://github.com/webark/ember-cli-styles/blob/9067ae607be0cd2f69b1e650c23833b62cccc97e/packages/preprocessor/lib/preprocessors.js

I moved the preprocessor packages into the dev dependencies, but should they be set as peerDependencies or optionalDependencies ? I always forget how these work Do you have any familiarity @boris-petrov ?

This should fix #8

boris-petrov commented 2 years ago

I think they should be in optionalDependencies as peerDependencies are actually required.

I didn't understand what you mean by your first paragraph. Should all style preprocessors be added for ember-cli-styles to work or only the ones that an app uses? Also, what is the "default set" used for?

P.S. I saw your messages in the PM so I think all is fine (as long as you move the dependencies to optionalDependencies).

I think this will also resolve (a major part of) #18.

webark commented 2 years ago

“All” meaning any number of them. (it’s designed so you can mix and match different styles types). And the default is just if people don’t want to think about it, they could just import that and either just add it all, or add what they want.

boris-petrov commented 2 years ago

@webark - is this PR good to go? Does it to what it says it does or it needs more work?

webark commented 2 years ago

I'll release this

boris-petrov commented 2 years ago

@webark - thanks for merging! I'm awaiting the release so I can test this. :)

webark commented 2 years ago

this was released.