search

webark / ember-component-css

An Ember CLI addon which allows you to specify styles for individual components
MIT License
540 stars 115 forks source link

Fails to build with addons using podModulePrefix #243

Open bretjb opened 7 years ago

bretjb commented 7 years ago

Hi! I'm developing a private addon to be consumed by my Ember app that I'd like to include styles for. The addon uses a pod structure and it also defines a podModulePrefix in config/environment.js. After adding ember-component-css, the build now fails with the following error:

Build failed.
The Broccoli Plugin: [BroccoliMergeTrees: Merge (ember-component-css merge pod and classic styles)] failed with:
Error: ENOENT: no such file or directory, scandir '/<cut>/dev/tmp/addon-pod-test/tmp/funnel-input_base_path-nt5VSwZt.tmp/addon-pod-test/pods/'
    at Error (native)
    at Object.fs.readdirSync (fs.js:952:18)
    at _walkSync (/<cut>/dev/tmp/addon-pod-test/node_modules/walk-sync/index.js:74:18)
    at Function.entries (/<cut>/dev/tmp/addon-pod-test/node_modules/walk-sync/index.js:50:10)
    at Funnel.processFilters (/<cut>/dev/tmp/addon-pod-test/node_modules/broccoli-funnel/index.js:320:26)
    at Funnel.build (/<cut>/dev/tmp/addon-pod-test/node_modules/broccoli-funnel/index.js:258:10)
    at /<cut>/dev/tmp/addon-pod-test/node_modules/broccoli-plugin/read_compat.js:93:34
    at tryCatch (/<cut>/dev/tmp/addon-pod-test/node_modules/rsvp/dist/rsvp.js:525:12)
    at invokeCallback (/<cut>/dev/tmp/addon-pod-test/node_modules/rsvp/dist/rsvp.js:538:13)
    at publish (/<cut>/dev/tmp/addon-pod-test/node_modules/rsvp/dist/rsvp.js:508:7)

The broccoli plugin was instantiated at:
    at BroccoliMergeTrees.Plugin (/<cut>/dev/tmp/addon-pod-test/node_modules/broccoli-plugin/index.js:7:31)
    at new BroccoliMergeTrees (/<cut>/dev/tmp/addon-pod-test/node_modules/ember-component-css/node_modules/broccoli-merge-trees/index.js:16:10)
    at Class._getStyleFunnel (/<cut>/dev/tmp/addon-pod-test/node_modules/ember-component-css/index.js:13:12)
    at Class.processComponentStyles (/<cut>/dev/tmp/addon-pod-test/node_modules/ember-component-css/index.js:141:26)
    at Class.treeForStyles (/<cut>/dev/tmp/addon-pod-test/node_modules/ember-component-css/index.js:135:19)
    at Class.superWrapper [as treeForStyles] (/<cut>/dev/tmp/addon-pod-test/node_modules/core-object/lib/assign-properties.js:34:20)
    at Class._treeFor (/<cut>/dev/tmp/addon-pod-test/node_modules/ember-cli/lib/models/addon.js:520:33)
    at Class.treeFor (/<cut>/dev/tmp/addon-pod-test/node_modules/ember-cli/lib/models/addon.js:480:21)
    at project.addons.map.addon (/<cut>/dev/tmp/addon-pod-test/node_modules/ember-cli/lib/broccoli/ember-app.js:559:22)
    at Array.map (native)

Removing podModulePrefix from environment.js allows the project to build once again.

I've included what I believe is a minimal repo case here: https://github.com/bretjb/ember-componentcss-bug

Please let me know if I'm missing a configuration setting, or what else I can do to help narrow down the issue. Thanks!

webark commented 7 years ago

@bretjb I'll look into this. But ya. I've run into issues with various addons when it comes to the pod module prefix. I'll try to find a solution for you.

kedano commented 7 years ago

I get the same issue, Ember-cli 2.14.2 and podModulePrefix setup.

timgthomas commented 6 years ago

I did some digging, and it seems the error is thrown by the "dummy" app's config: setting it up to use pods solved the error on my build (using Ember CLI 2.13.3, which is what the repro repo uses). I have a PR up for that repo that has the changes.