search

webark / ember-component-css

An Ember CLI addon which allows you to specify styles for individual components
MIT License
540 stars 115 forks source link

Upgrading Ember breaks namespaces? #349

Open BlueRaja opened 4 years ago

BlueRaja commented 4 years ago

We're attempting to upgrade from Ember 2.18 to Ember 3.16. Most things are working, but our CSS is borked. The problem seems to be that ember-component-css is injecting namespace classes in the CSS, but not in the actual DOM.

We're still using the old syntax for most things, including

export default Component.extend({
  ...
});

Could this be the cause?

Workaround:

In environment.js, add

const ENV = {
  ...
  'ember-component-css': {
    namespacing: false,
  },
}

then everywhere you are using &{ ... } in the root of your SCSS needs to be replaced with a manually-created root class

webark commented 4 years ago

Yes. This stopped working around ember 3.15 :/ I'm sorry. I have spent part of the week finally making some final progress on a solutions and should have soon.

Sorry for the broken functionality and the frustration I'm sure it has caused :(

derekwsgray commented 1 year ago

Is this still an issue? I need the styleNamespace for working with D3

webark commented 1 year ago

I have not been working on ember for several years. There was rewrite that I did of this "ember-cli-styles", but I am not commuting to maintaining that ☹️ There has been some success with people using it however. If there are changes you discover, or improvements you want to make, I can review the PRs for either.