webarkit / ARnft-threejs

A rendering package for https://github.com/webarkit/ARnft
GNU General Public License v3.0
23 stars 8 forks source link

Video/Image always square. Any settings that could support width/height ratio tuning? #14

Closed ronaldyang closed 2 years ago

ronaldyang commented 3 years ago

This toolkit is so awesome that I almost had no trouble to set things up :)

During my test, ideally we would love to cover the whole marker with media content. While under default setting, the height and width are almost identical even it is a 1024x480 or 360x720 media file.

@kalwalt Any input or code modification guidance would be appreciated. Thanks in advance!!

Also some heads up: the video is blacked out in iOS 14.6 (which never happened in previous iOS releases). I guess it is relevant with new privacy rules introduced.

kalwalt commented 3 years ago

This toolkit is so awesome that I almost had no trouble to set things up :)

During my test, ideally we would love to cover the whole marker with media content. While under default setting, the height and width are almost identical even it is a 1024x480 or 360x720 media file.

@kalwalt Any input or code modification guidance would be appreciated. Thanks in advance!!

Also some heads up: the video is blacked out in iOS 14.6 (which never happened in previous iOS releases). I guess it is relevant with new privacy rules introduced.

@ronaldyang Sorry for the delay! I have limited time until the end of september. About the width and the height: i think you are refering to the addVideo function, Now with the the new version is outside ARnft and is in a separate repository https://github.com/webarkit/ARnft-threejs see here https://github.com/webarkit/ARnft-threejs/blob/a36b5037b8784f92d44e49c5e1933e9f73831588/src/markermedia/NFTaddTJS.ts#L53-L68 For sure need an improvement, there is also some issues with Firefox and other browsers https://github.com/webarkit/ARnft-threejs/issues/8 Maybe you have an idea?

kalwalt commented 2 years ago

@ronaldyang this was done in PR https://github.com/webarkit/ARnft-threejs/pull/26 let me know if it is ok for you. Closing this, open another issue if you have troubles.