webarkit / ARnft-threejs

A rendering package for https://github.com/webarkit/ARnft
GNU General Public License v3.0
22 stars 7 forks source link

WARNING: Multiple instances of Three.js being imported. #23

Open kalwalt opened 3 years ago

kalwalt commented 3 years ago

I receive this warning i think it would be better to avoid it. I found this article in the Three.js forum https://discourse.threejs.org/t/warning-multiple-instances-of-three-js-being-imported/24191, not sure why it's happening.

albjeremias commented 2 years ago

I'm researching on this...

https://stackoverflow.com/questions/67271915/warning-multiple-instances-of-three-js-being-imported

It seems fixed in here: 0.128

https://github.com/mrdoob/three.js/issues/17482

kalwalt commented 2 years ago

Thank you @albjeremias but ARnftThreejs already import version r128 see https://github.com/webarkit/ARnft-threejs/blob/82edc0f2c9a1f04da395d80b45d5812ee7b16804/package.json#L49 But maybe the three.js lib inside the example not? I will check and test with a live package.

kalwalt commented 2 years ago

This issue i think happens now only when ARnft, ArnftThreejs and Three.js are imported as a module see for an example my project t ARnft-ES6-react you can test here https://kalwalt.github.io/ARnft-ES6-react/

kalwalt commented 2 years ago

i will move also this to the ARnft-threejs issue tracker, ARnft itself it's not the root of this because not load Three.js itself.