search

webarkit / ARnft-threejs

A rendering package for https://github.com/webarkit/ARnft
GNU General Public License v3.0
23 stars 8 forks source link

Expose planeGeometry for addVideo to support different video ratios #25

Closed JamesBotterill closed 2 years ago

JamesBotterill commented 2 years ago

At present the plane geometry for a video has a fixed planeGeometry of [1,1,1,1] which just creates a very basic square or a 1:1 ratio video , this really isn't helpful as the vast majority of videos are 16:9. This makes any video of a video other than 16:9 display incorrectly.

I would propose that you expose these at as a argument when adding a video to a scene using ARnft, I would also expose the height and width segmentation too.

kalwalt commented 2 years ago

At present the plane geometry for a video has a fixed planeGeometry of [1,1,1,1] which just creates a very basic square or a 1:1 ratio video , this really isn't helpful as the vast majority of videos are 16:9. This makes any video of a video other than 16:9 display incorrectly.

I would propose that you expose these at as a argument when adding a video to a scene using ARnft, I would also expose the height and width segmentation too.

Good point! Yes i think it need an improvement, let my see what i can do.

kalwalt commented 2 years ago

done with PR #26