webarkit / ARnft-threejs

A rendering package for https://github.com/webarkit/ARnft
GNU General Public License v3.0
22 stars 7 forks source link

Improving add video function #32

Closed kalwalt closed 2 years ago

kalwalt commented 2 years ago

This PR simply add ARVideo.play only inside the addEventListener: https://github.com/webarkit/ARnft-threejs/blob/414d6a5bb7c61db0a65c50fdb5acfcdd28e137fd/src/markermedia/NFTaddTJS.ts#L297-L316 and pause it in the trackingLost addEventListener: https://github.com/webarkit/ARnft-threejs/blob/414d6a5bb7c61db0a65c50fdb5acfcdd28e137fd/src/markermedia/NFTaddTJS.ts#L317-L321 This should improve performances. Updated also some pkgs.