webarkit / ARnft

A small javascript library for WebAR with NFT
GNU Lesser General Public License v3.0
220 stars 54 forks source link

More than one NFT markers #146

Closed papadako closed 3 years ago

papadako commented 3 years ago

Dear all,

thanks for ARnft! Seems to be working great!

It seems that tracking more than one NFT markers is currently not available! Is this correct? Do you plan to implement this feature?

Best regards and thanks for your nice work!

kalwalt commented 3 years ago

Hi @papadako! You are welcome :smile:

It seems that tracking more than one NFT markers is currently not available! Is this correct? Do you plan to implement this feature?

No this is not implemented, but it is one feature to add for sure. At the moment you can find this feature implemented in our jsartoolkit5 fork https://github.com/webarkit/jsartoolkit5 we haven't any examples at the moment but i hope soon that we can provide some snippet.

eddiecarbin commented 3 years ago

Do you mean more than one marker with the same image and model or multiple markers with different images and models?

More than one marker is possible with the existing code. I got it to work with the artoolkit_wasm.js. I created an AR controller object for each marker. Create a new worker for each marker you want to track. It doesn't track multiple markers with the same image.

The worker returns a matrix and you have to move the 3d model and not the camera with the adjusted matrix

kalwalt commented 3 years ago

Do you mean more than one marker with the same image and model or multiple markers with different images and models?

More than one marker is possible with the existing code. I got it to work with the artoolkit_wasm.js. I created an AR controller object for each marker. Create a new worker for each marker you want to track. It doesn't track multiple markers with the same image.

The worker returns a matrix and you have to move the 3d model and not the camera with the adjusted matrix

I think he means more that one markers not multi markers as in Artoolkit5 ( multi markers that act as only one for a more robust feature detection and tracking) It would be easier and more efficient if i implement the loadNFTmarkers as in our jsartoolkit5 https://github.com/webarkit/jsartoolkit5/blob/7f998d00582d86fe95d573e539ddeea9380ccc4e/js/artoolkit.api.js#L579-L585 I can port this to jsartoolkitNFT and then in ARnft.

papadako commented 3 years ago

Do you mean more than one marker with the same image and model or multiple markers with different images and models?

More than one marker is possible with the existing code. I got it to work with the artoolkit_wasm.js. I created an AR controller object for each marker. Create a new worker for each marker you want to track. It doesn't track multiple markers with the same image.

The worker returns a matrix and you have to move the 3d model and not the camera with the adjusted matrix

Hello @eddiecarbin,

what I want to do is to track 15 different images and use them as a base for providing a UI on top of them for interaction using babylon.js. Can I implement something like this using babylon?

I would appreciate if you could provide a code sample for what you describe.

kalwalt commented 3 years ago

@papadako The multi NFT feature is in the master now see PR #199 for details.

papadako commented 3 years ago

Excellent!

BR

albjeremias commented 3 years ago

close