Open kalwalt opened 1 year ago
To be clear this.video is the getters defined here https://github.com/webarkit/ARnft/blob/5a669820c6ea8fe088a344492bff14592dc201d3/src/renderers/CameraViewRenderer.ts#L99-L101 I'm wondering if this make sense or not. Could we get the _video (private) directly?
Inside the CameraViewRenderer (getImage and image getter) there is a reference to this.video:
https://github.com/webarkit/ARnft/blob/5a669820c6ea8fe088a344492bff14592dc201d3/src/renderers/CameraViewRenderer.ts#L122 and: https://github.com/webarkit/ARnft/blob/5a669820c6ea8fe088a344492bff14592dc201d3/src/renderers/CameraViewRenderer.ts#L138
but video is not declared or defined in the class, we have only the _video member: https://github.com/webarkit/ARnft/blob/5a669820c6ea8fe088a344492bff14592dc201d3/src/renderers/CameraViewRenderer.ts#L55 We need to check the correctness of this and if this may lead to some bugs.