search

webarkit / jsartoolkit5

Javascript ARToolKit v5.x
https://webarkit.github.io/jsartoolkit5/examples/
Other
12 stars 8 forks source link

Compression feature #11

Closed Carnaux closed 3 years ago

Carnaux commented 3 years ago

Added the new compression system using zlib, please check the code and test it!

Carnaux commented 3 years ago

This doesn't load multiple markers, checking it now

kalwalt commented 3 years ago

@Carnaux I will check when i have time, i think this is a must!

Carnaux commented 3 years ago

@Carnaux testing your PR, i will leave some comments in the code. I have tested the examples and all fine the pinball marker load, but the model (the sphere) onto the marker looks very little in respect when using the old not compressed pinball version, Maybe do you created a .zft marker with low dpi? I hope that this was the cause... If you compare in the nft multi example the three differents markers you will notice a great difference. This is the first tests i have done, i would also test the whole build process, wondering if your docker commands works or is your set-up...

I believe the marker was 72 or 220, if you have time you can try to generate it with the node version, we need something to analyze the generated markers to ensure quality.

kalwalt commented 3 years ago

@Carnaux testing your PR, i will leave some comments in the code. I have tested the examples and all fine the pinball marker load, but the model (the sphere) onto the marker looks very little in respect when using the old not compressed pinball version, Maybe do you created a .zft marker with low dpi? I hope that this was the cause... If you compare in the nft multi example the three differents markers you will notice a great difference. This is the first tests i have done, i would also test the whole build process, wondering if your docker commands works or is your set-up...

I believe the marker was 72 or 220, if you have time you can try to generate it with the node version, we need something to analyze the generated markers to ensure quality.

I will try to build a new one, and will test the build process.

kalwalt commented 3 years ago

Daniel @Carnaux i have tested with a new .zft with 300 dpi and it displayed big as in the old examples. If i can i will test the build process, and if it is ok i will merge it.

kalwalt commented 3 years ago

@Carnaux trying to build the Emscripten libs i get some errors, i think related to the Emscripten version used, im testing with the latest emsdk 2.0.20 but i think the jsartoolkit5 project still require an older version (fastcomp), can you tell me which version you used?

kalwalt commented 3 years ago

It is possible to build the jsartoolkit5 EM libs also with the latest emsdk; Inside tools/makem.js It's needed to remove the var WASM_FLAGS = ' -s BINARYEN_TRAP_MODE=clamp' because it was removed in upstream, and change the line:

  -o {OUTPUT_PATH}libar.bc

to 

  -r -o {OUTPUT_PATH}libar.bc

But i think this will break the automated build script for the releases. We can fix this in another PR. @ThorstenBux if it is ok for you we can merge this.

Carnaux commented 3 years ago

@kalwalt I used 2.0.15 with the docker container.

The 300 dpi markers take a good time to be created, right? I think is time to take a look at that then.

kalwalt commented 3 years ago

@kalwalt I used 2.0.15 with the docker container.

Really? i will test with it then.

The 300 dpi markers take a good time to be created, right? I think is time to take a look at that then.

Yes, it takes a quite good time, do you think that is a difference creating a .zft and a .fset .iset .fset3?

Carnaux commented 3 years ago

Yes, it takes a quite good time, do you think that is a difference creating a .zft and a .fset .iset .fset3?

There is some difference between the markers, the model size is one, but I don't know why, the compression system used was lossless, so it should be the same marker. It takes a long time mostly because of the current feature extraction.

You can test only the compression here https://github.com/Carnaux/ZFT-Creator

kalwalt commented 3 years ago

I will test It. I will post also the new Pinball 300 DPI .zft marker, when i will back to my PC. So you will be able to commit that file 🙂.

kalwalt commented 3 years ago

Attached the new pinball.zft (zipped) if you want to test and add to the PR in a commit. pinball.zip

Carnaux commented 3 years ago

Will add it

kalwalt commented 3 years ago

Sorry for the delay @Carnaux @ThorstenBux I think we can merge this!

Carnaux commented 3 years ago

Hey, no problem, I've been using it in a commercial application for almost a year and i got no complaints about it.

kalwalt commented 3 years ago

Very good job Daniel! We will see to improve NFT-Marke-Creator then... I'm merging this. :smile: