search

webarkit / jsartoolkit5

Javascript ARToolKit v5.x
https://webarkit.github.io/jsartoolkit5/examples/
Other
12 stars 8 forks source link

build jsartoolkit5 with working emscripten #15

Open albjeremias opened 3 years ago

albjeremias commented 3 years ago

this makes possible to compile jsartoolkit5 using latest emscripten version

I removed the BINARYEN_TRAP_MODE=clamp cause it seems emscript does it by default! stderr: emcc: error: Invalid command line option -s BINARYEN_TRAP_MODE=clamp: The wasm backend does not support a trap mode **(it always clamps, in effect)**

and the -r option is for .bc files to be supported by emscripten latest https://github.com/emscripten-core/emscripten/issues/13206#issuecomment-756703476

albjeremias commented 3 years ago

^^

the fastcomp backend is not getting new builds or releases. Please use the upstream llvm backend or use an older version than 2.0.0 (such as 1.40.1)

when compiling without fastcomp.. the app crashes with "Out of memory".. well i can't compile with fastcomp.. so i guess its that..:s

kalwalt commented 3 years ago

^^

the fastcomp backend is not getting new builds or releases. Please use the upstream llvm backend or use an older version than 2.0.0 (such as 1.40.1)

when compiling without fastcomp.. the app crashes with "Out of memory".. well i can't compile with fastcomp.. so i guess its that..:s

Have you tried with the latest emsdk? Take as reference JsartoolkitNFT for an updated makem.js and build instructions. Anyway i will test your changes when i can. I had always would switch to a newer emscripten version for jsartoolkit5...

kalwalt commented 3 years ago

The code is ok! Tested with emsdk 2.0.20 i will fix the conflicts and then i will merge it.

albjeremias commented 3 years ago

merged with master.. ready :)

kalwalt commented 3 years ago

merged with master.. ready :)

Thank you @albjeremias i will make a quick check/test soon!

albjeremias commented 3 years ago

I was not able to use the master branch.. it get: https://github.com/webarkit/jsartoolkit5/issues/16

so i regressed to the commit: 4ed7e4b127f2b79cb4a19cac2266c29c06be69cf

and made the changes on the makem.js

please lets fix the regression before merging this. i will fill an issue

kalwalt commented 3 years ago

Ok i will wait. Just ping me when Is ready. 🙂

albjeremias commented 3 years ago

Ok i will wait. Just ping me when Is ready. slightly_smiling_face

its ready... maybe we can postpone solving the issue #16 ... but i now made a branch from the commits before zft...