search

webarkit / jsartoolkitNFT

jsartolkitNFT is a smaller version of jsartoolkit5 with only NFT support
GNU Lesser General Public License v3.0
131 stars 25 forks source link

delegateMethods interface should be outisde ARControllerNFT #232

Closed kalwalt closed 1 year ago

kalwalt commented 1 year ago

We could put the delegateMethods interface https://github.com/webarkit/jsartoolkitNFT/blob/9277579a055a20ec1bee1e8f9437b273ea9806ed/src/ARControllerNFT.ts#L46-L112 outside the class so it could be also accessed by ARToolkitNFT, in detail the instance property https://github.com/webarkit/jsartoolkitNFT/blob/9277579a055a20ec1bee1e8f9437b273ea9806ed/src/ARToolkitNFT.ts#L56 could be declared with that interface intead the odd any declaration.

kalwalt commented 1 year ago

done with PR #246