search

webarkit / jsartoolkitNFT

jsartolkitNFT is a smaller version of jsartoolkit5 with only NFT support
GNU Lesser General Public License v3.0
131 stars 25 forks source link

Developing the ES6 version of the lib #24

Closed kalwalt closed 3 years ago

kalwalt commented 4 years ago

Collecting here all the resources for converting the project to the ES6 standard. Initially i was thinking that this should be done in another step but maybe better do this as soon as possible. There are some difficulties for me to convert the code to the ES6 standard. Not much for the arNFT lib but most for JsartoolkitNFT. In particular convert the addNFTMarker https://github.com/kalwalt/jsartoolkitNFT/blob/bc2e61c413dda6b3b72e10776eff3ec1a0e574ea/js/artoolkitNFT.api.js#L963-L977 method to ES6. I need to solve this problem. This is the most important.

kalwalt commented 4 years ago

I am working on this with #27 for arNFT, will add ES6 to jsartoolkitNFT in another PR.

kalwalt commented 4 years ago

I have moved all the ARnft code to the new repository https://github.com/kalwalt/ARnft, i will continue here only the JsartoolkitNFT related code.

kalwalt commented 4 years ago

update: in this branch https://github.com/kalwalt/jsartoolkitNFT/tree/ES6 i'm working on the ES6 feature. actually it compile fine, no errors in the console but it seems that the pinball image is not detected tracked. See the https://github.com/kalwalt/jsartoolkitNFT/blob/ES6/examples/ARToolkitNFT_ES6_example.html example I have to find the reason for this.

kalwalt commented 3 years ago

ES6 was merged in dev with https://github.com/webarkit/jsartoolkitNFT/pull/63 https://github.com/webarkit/jsartoolkitNFT/pull/77