search

webarkit / jsartoolkitNFT

jsartolkitNFT is a smaller version of jsartoolkit5 with only NFT support
GNU Lesser General Public License v3.0
130 stars 26 forks source link

Verify if detectMarker is strictly needed #361

Closed kalwalt closed 5 months ago

kalwalt commented 6 months ago

detectMarker method definded in ARToolkitNFT https://github.com/webarkit/jsartoolkitNFT/blob/7a9524e91e96624290cadeb2f45c1b1e833e35c0/src/ARToolkitNFT.ts#L236-L238 corresponding WASM code from C++ https://github.com/webarkit/jsartoolkitNFT/blob/7a9524e91e96624290cadeb2f45c1b1e833e35c0/emscripten/ARToolKitNFT_js.cpp#L402-L411 we should check if this is strictly required otherwise we can remove it.

kalwalt commented 5 months ago

That code was removed with #362