Testing if detectMarker is necessary

webarkit / jsartoolkitNFT

jsartolkitNFT is a smaller version of jsartoolkit5 with only NFT support

GNU Lesser General Public License v3.0

130 stars 26 forks source link

Testing if detectMarker is necessary #362

Closed kalwalt closed 6 months ago

kalwalt commented 6 months ago

For more infos go to issue #361

List of features:

[x] test if detectMarker is necessary and remove the code if not.
[x] upgrading packages
[x] upgrading emsdk to 3.1.40 version see comment and comment linked issue #363

kalwalt commented 6 months ago

I can't build the build libs with emsdk 3.1.50, i will open a separate issue for that, for now i will try with an older version but major of 3.1.32

kalwalt commented 6 months ago

I can't build the build libs with emsdk 3.1.50, i will open a separate issue for that, for now i will try with an older version but major of 3.1.32

The libs can be build with emsdk 3.1.40 the only issue that we have now: the log message from ARLOG's print in the console.error message (intead of console.warning, this change was done in version 3.1.39 ), i will change this behaviour.

kalwalt commented 6 months ago

I think it is almost ready, will be merged when PR https://github.com/webarkit/WebARKitLib/pull/26 is done.