Closed GoogleCodeExporter closed 9 years ago
This must be optional if it's implemented..
Original comment by par.toma...@gmail.com
on 20 Nov 2009 at 10:05
[deleted comment]
Please accept this patch. I allows you to specify sounds for:
1) Succeeded
2) Failed
3) Fixed
4) Still failing
I have not yet added a UI to set these. For now you would add the following to
your
hudson.properties file:
sound[0].failed=C:\houston.wav
sound[0].fixed=C:\hallelujah.wav
sound[0].stillfailing=C:\bunny.wav
sound[0].succeeded=C:\horray.wav
If someone else wants to add a UI, that would be great. I will add when it gets
painful enough to not have it.
Another thing I should mention is that I had to upgrade the solution to VS 2008
in
order to make the changes because I do not have an earlier version. However, I
made
a point to use only .NET 2.0 syntax.
Original comment by timtast...@gmail.com
on 20 Nov 2009 at 3:52
Attachments:
Great, a contribution :)
I will review the patch and integrate it. I will see for the UI as well.
Thanks.
Original comment by Alexis.S...@gmail.com
on 20 Nov 2009 at 4:21
Original comment by Alexis.S...@gmail.com
on 23 Nov 2009 at 2:13
Please try this version and let me know what you think:
http://hudson-tray-tracker.googlecode.com/files/HudsonTrayTrackerInstaller_v0.9.
7_beta.exe
There is an extra tab in the settings window to configure the sounds. However,
I have
slightly changed the format of the configuration file so it won't load existing
settings, but then it should work.
Original comment by Alexis.S...@gmail.com
on 23 Nov 2009 at 2:49
Awesome! Seems to work great. I am pondering a few questions.
First, unlike CCtray, HTT sound notifications are based on the worst status.
So
let's say I have 5 projects, and two are broken. I force the build on one of
the
broken projects, and it succeeds. I will get the "still failing" alert because
there
is still one broken project. I asked some co-workers, and they think this
behavior
is okay. However, it might be a little surprising or confusing. We might
consider
making the sounds are more fine grained (per project). Not sure what's best.
Second, I have been trying to better understand Hudson statuses. I wonder if
we
should treat Unstable the same as Failed. Or maybe Unstable could have it's
own
sounds, that seems a little too fine grained. It's not something I personally
care
about because we treat failing tests as a failure. Thoughts?
Last, I wonder how to treat Stuck. I encountered this this morning because our
SVN
server went down. My tray icon is red, and when I force a build it fails, but
there
is no sound because the "worst status" is stuck. Maybe this is okay.
Original comment by timtast...@gmail.com
on 23 Nov 2009 at 5:08
I have removed v0.9.7 which was not working well. Instead, if you want to try,
take
the version 0.9.8.
Original comment by Alexis.S...@gmail.com
on 23 Nov 2009 at 6:01
Here is another patch. After a few days of using HTT with the sound
notifications, I
have concluded that it needs more fine grained handling. With this patch, HTT
will
give a sound notification whenever a build for any project finishes, and the
notification will indicate the the outcome of that build, as opposed to the
worst
status. I think that this behavior is more useful and less surprising to the
user.
You will notice that I added a setting "sounds.TreatUnstableAsFailed" which I
have
defaulted to TRUE. I envision this as a checkbox on the sound notifications
tab of
settings. I was not able to add this. When I tried to open the designer, I
got an
exception, probably because I do not have DevExpress. The idea for this
setting is
that the user can decide if Unstable (failing tests, for example) should
trigger the
failing sounds.
I noticed that the latest trunk uses VS 2008 project format. Therefore, these
code
changes take advantage of features available in 08 such as auto properties.
I hope you like these changes! Thanks again for HTT
Original comment by timtast...@gmail.com
on 30 Nov 2009 at 6:08
Attachments:
Thanks for the patch! I will try to integrate it tomorrow.
Original comment by Alexis.S...@gmail.com
on 3 Dec 2009 at 10:04
Original issue reported on code.google.com by
timtast...@gmail.com
on 17 Nov 2009 at 12:22