search

webasyst / webasyst-framework

Webasyst PHP Framework
http://www.webasyst.com/
GNU Lesser General Public License v3.0
290 stars 202 forks source link

Update waPlugin::buildFullTemplatePath() #349

Closed WinterSilence closed 1 year ago

WinterSilence commented 2 years ago

Extends method comment and optimizes his code.

mikeushenin commented 2 years ago

Fixing what issue is your pull request aimed at?

WinterSilence commented 2 years ago

@mikeushenin optimization + normalization Windows paths

mikeushenin commented 2 years ago

@mikeushenin optimization + normalization Windows paths

You have described the purpose of your code changes but not the issue which they are supposed to fix. Please describe how to reproduce the issue that will occur with the use of the current code state, before your changes.

WinterSilence commented 2 years ago

waPlugin::buildFullTemplatePath('actions', '\frontend\pluginAction.html');

You have described the purpose of your code changes but not the issue which they are supposed to fix.

PR does not necessarily fix some bug/issue, it's can be refactoring or new features.