search

webatintel / aquarium

BSD 3-Clause "New" or "Revised" License
24 stars 7 forks source link

Add option --msaa-sample-count #123

Closed gyagp closed 4 years ago

gyagp commented 4 years ago

MSAA sample count is no longer fixed in 4. Instead, its value can be designated by option, with default value as 4.

gyagp commented 4 years ago

@hujiajie, PTAL!

hujiajie commented 4 years ago

@gyagp Thanks for the patch!

To summarize the bot failure, refs/pull/origin/<pr>/merge is assumed to be the triggering commit in our CI scripts, but GitHub creates a separate commit this time. I don't know if it's intentional. Can you git commit --amend your patch and git push -f again?

And I'd like to mention the existing --enable-alpha-blending option. I hope to have consistent command-line syntax here, so either you need to update your patch, or we will change the other next.

gyagp commented 4 years ago

This is a good point. I removed --enable-msaa option and unified to --msaa-sample-count (1 means no MSAA). For option "--enable-alpha-blending", I think we also need to change its name to "--alpha-blending", while 1 means opaque.

gyagp commented 4 years ago

Done

hujiajie commented 4 years ago

Thanks! Merging