search

webatintel / aquarium

BSD 3-Clause "New" or "Revised" License
24 stars 7 forks source link

Aquarium is no longer a fan of aligning things #147

Closed hujiajie closed 3 years ago

hujiajie commented 3 years ago

Remove AlignOperands because it's true by default.

AlignConsecutiveAssignments is controversial because it would align things that are semantically unrelated, e.g.:

https://github.com/webatintel/aquarium/commit/04b6470233329eaf3cf895ca7580681fcd92a2f2#diff-9a8ca2d3748c25f356bccc804a4af28aR51-R52

Again, the style is advisory instead of compulsory.

This pull request is opened using a shared GitHub account. Please find the actual author in the git log, and use "Rebase and merge" for correct attribution. The author may have no access to this account, so please do not assume there will be replies from a real human. But you can still leave a comment, and code will be updated here once addressed. - Your Sincere Bot

gyagp commented 3 years ago

LGTM. Personally I'm also not a fan of AlignConsecutiveAssignments:)