Closed hujiajie closed 3 years ago
This manual intervention works as a prerequisite to fix the macOS build. The required GN revision was actually raised by a previous roll of Dawn, for the new weak_frameworks linking option:
https://github.com/webatintel/aquarium/pull/157 https://dawn.googlesource.com/dawn.git/+log/0d52f800a1d1..c4c4ff9eb4b5 https://dawn-review.googlesource.com/c/dawn/+/24281 https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2c41dfb19abe..c8f5482fd0c9 https://gn-review.googlesource.com/c/gn/+/8464
Since the macOS build is suffering from other issues, the pull request had slipped in by accident.
This manual intervention works as a prerequisite to fix the macOS build. The required GN revision was actually raised by a previous roll of Dawn, for the new weak_frameworks linking option:
https://github.com/webatintel/aquarium/pull/157 https://dawn.googlesource.com/dawn.git/+log/0d52f800a1d1..c4c4ff9eb4b5 https://dawn-review.googlesource.com/c/dawn/+/24281 https://chromium.googlesource.com/chromium/src/buildtools.git/+log/2c41dfb19abe..c8f5482fd0c9 https://gn-review.googlesource.com/c/gn/+/8464
Since the macOS build is suffering from other issues, the pull request had slipped in by accident.